Issue 113625: Disable compilation cache when debugger is active

Issue 113625: Disable compilation cache when debugger is active (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Disable compilation cache when debugger is active. Added an option to control whether the compilation cache is enabled. Default value is true. BUG=343 Committed: http://code.google.com/p/v8/source/detail?r=2021

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -7 lines)			Patch
M	src/compilation-cache.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compilation-cache.cc	View	1 2	8 chunks	+41 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	1 2	3 chunks	+15 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 2	4 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM, but it would be extra nice with command line flag to disable the compilation ...

11 years, 7 months ago (2009-05-20 08:33:08 UTC) #2

Søren Thygesen Gjesse

11 years, 7 months ago (2009-05-20 08:43:53 UTC) #3

Added flag --compilation-cache which defaults to true.

http://codereview.chromium.org/113625/diff/1/5
File src/compilation-cache.cc (right):

http://codereview.chromium.org/113625/diff/1/5#newcode292
Line 292: enabled = true;
On 2009/05/20 08:33:08, Kasper Lund wrote:
> It would be great if you could add a flag to control this behavior too - so we
> could always disable the compilation cache if we want to.

Added flag --compilation-cache which defailts to true.

http://codereview.chromium.org/113625/diff/1/5#newcode293
Line 293: Clear();
On 2009/05/20 08:33:08, Kasper Lund wrote:
> Is this Clear really meaningful?

Not really - removed.

http://codereview.chromium.org/113625/diff/1/4
File src/debug.cc (right):

http://codereview.chromium.org/113625/diff/1/4#newcode2177
Line 2177: // Disable the compilation cache when the debugger is active.
On 2009/05/20 08:33:08, Kasper Lund wrote:
> I guess SetEventListener and SetMessageHandler are used to both activate and
> deactivate the debugger?

Yes you pass NULL to remove the listener/handler currently active.

Expand Messages | Collapse Messages