Fix: infolist requries description title.

Fix: infolist requries description title.

Sorry I misunderstand the infolist spec, infolist requires title field.
I split description field into description_title and description_body.

BUG=129403
TEST=ran chromeos_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168544

[satorux1, 2012-11-08 08:24:16]

side-by-side diffs don't work for some reason. Could you upload again?

[Seigo Nonaka, 2012-11-08 08:28:29]

Opps, sorry uploaded.

[satorux1, 2012-11-08 08:39:30]

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
File chromeos/dbus/ibus/ibus_text_unittest.cc (right):

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
chromeos/dbus/ibus/ibus_text_unittest.cc:161: // Write attachment field.
Maybe 

// Write attachment fields.

because we have two fields now.

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
chromeos/dbus/ibus/ibus_text_unittest.cc:189:
attachment_array_writer.CloseContainer(&body_entry_writer);
Hmm, adding an attachment field seems to be a lot of code. Can you write a
helper function to do this? The function can be used elsewhere in the test.

[Seigo Nonaka, 2012-11-12 06:13:11]

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
File chromeos/dbus/ibus/ibus_text_unittest.cc (right):

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
chromeos/dbus/ibus/ibus_text_unittest.cc:161: // Write attachment field.
Sure will do.
On 2012/11/08 08:39:30, satorux1 wrote:
> Maybe 
> 
> // Write attachment fields.
> 
> because we have two fields now.

http://codereview.chromium.org/11362111/diff/8001/chromeos/dbus/ibus/ibus_tex...
chromeos/dbus/ibus/ibus_text_unittest.cc:189:
attachment_array_writer.CloseContainer(&body_entry_writer);
Sure, and I found that we need supporting writing attachment fields for some
reasons: infolist or annotation support for Extension IME API.
So let me pending this CL until http://codereview.chromium.org/11361210/
landing.

Thanks.
On 2012/11/08 08:39:30, satorux1 wrote:
> Hmm, adding an attachment field seems to be a lot of code. Can you write a
> helper function to do this? The function can be used elsewhere in the test.

[Seigo Nonaka, 2012-11-19 07:42:40]

ping? just in case

[satorux1, 2012-11-19 08:13:25]

LGTM

[commit-bot: I haz the power, 2012-11-19 15:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11362111/11006

[commit-bot: I haz the power, 2012-11-19 17:16:46]

Change committed as 168544