New APIs for external byte arrays

runtime/include/dart_api.h

Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index be97d76bc6b58782a843eb13b2e2e96f55dd3637..58251908cd775944ffb2a7e7a01a88cc9181933a 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -1620,6 +1620,16 @@ DART_EXPORT Dart_Handle Dart_ListSetAsBytes(Dart_Handle list,
  */
 DART_EXPORT bool Dart_IsByteArray(Dart_Handle object);
 
+

[cshapiro, 2012/11/01 00:40:19]

Remove this line.  1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+/**
+ * Is this object an external ByteArray?
+ *
+ * An external ByteArray is a ByteArray which references a fixed array of
+ * bytes which is external to the Dart heap.
+ */
+DART_EXPORT bool Dart_IsExternalByteArray(Dart_Handle object);

[cshapiro, 2012/11/01 00:40:19]

I would prefer this to be named Dart_IsByteArrayExternal.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+
+

[cshapiro, 2012/11/01 00:40:19]

Remove this line.  1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

 /**
  * Returns a ByteArray of the desired length.
  *
@@ -1630,6 +1640,7 @@ DART_EXPORT bool Dart_IsByteArray(Dart_Handle object);
  */
 DART_EXPORT Dart_Handle Dart_NewByteArray(intptr_t length);
 
+

[cshapiro, 2012/11/01 00:40:19]

1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

 /**
  * Returns a ByteArray which references an external array of 8-bit bytes.
  *
@@ -1646,6 +1657,13 @@ DART_EXPORT Dart_Handle Dart_NewExternalByteArray(uint8_t* data,
                                                   Dart_PeerFinalizer callback);
 
 /**
+ * Retrieves the data pointer associated with an external ByteArray.
+ */
+DART_EXPORT Dart_Handle Dart_ExternalByteArrayGetData(Dart_Handle object,
+                                                      void** data);
+
+

[cshapiro, 2012/11/01 00:40:19]

1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+/**
  * Retrieves the peer pointer associated with an external ByteArray.
  */
 DART_EXPORT Dart_Handle Dart_ExternalByteArrayGetPeer(Dart_Handle object,