New APIs for external byte arrays

runtime/include/dart_api.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef INCLUDE_DART_API_H_
 #define INCLUDE_DART_API_H_
 
 /** \mainpage Dart Embedding API Reference
  *
  * Dart is a class-based programming language for creating structured
@@ skipping 1602 matching lines @@
                                             uint8_t* native_array,
                                             intptr_t length);
 
 // --- Byte Arrays ---
 
 /**
  * Is this object a ByteArray?
  */
 DART_EXPORT bool Dart_IsByteArray(Dart_Handle object);
 
+

[cshapiro, 2012/11/01 00:40:19]

Remove this line.  1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+/**
+ * Is this object an external ByteArray?
+ *
+ * An external ByteArray is a ByteArray which references a fixed array of
+ * bytes which is external to the Dart heap.
+ */
+DART_EXPORT bool Dart_IsExternalByteArray(Dart_Handle object);

[cshapiro, 2012/11/01 00:40:19]

I would prefer this to be named Dart_IsByteArrayExternal.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+
+

[cshapiro, 2012/11/01 00:40:19]

Remove this line.  1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

 /**
  * Returns a ByteArray of the desired length.
  *
  * \param length The length of the array.
  *
  * \return The ByteArray object if no error occurs. Otherwise returns
  *   an error handle.
  */
 DART_EXPORT Dart_Handle Dart_NewByteArray(intptr_t length);
 
+

[cshapiro, 2012/11/01 00:40:19]

1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

 /**
  * Returns a ByteArray which references an external array of 8-bit bytes.
  *
  * \param value An array of 8-bit bytes. This array must not move.
  * \param length The length of the array.
  * \param peer An external pointer to associate with this byte array.
  *
  * \return The ByteArray object if no error occurs. Otherwise returns
  *   an error handle.
  */
 DART_EXPORT Dart_Handle Dart_NewExternalByteArray(uint8_t* data,
                                                   intptr_t length,
                                                   void* peer,
                                                   Dart_PeerFinalizer callback);
 
 /**
+ * Retrieves the data pointer associated with an external ByteArray.
+ */
+DART_EXPORT Dart_Handle Dart_ExternalByteArrayGetData(Dart_Handle object,
+                                                      void** data);
+
+

[cshapiro, 2012/11/01 00:40:19]

1 space between definitions in this header.

[Søren Gjesse, 2012/11/01 07:46:03]

Done.

+/**
  * Retrieves the peer pointer associated with an external ByteArray.
  */
 DART_EXPORT Dart_Handle Dart_ExternalByteArrayGetPeer(Dart_Handle object,
                                                       void** peer);
 
 /**
  * Gets an int8_t at some byte offset in a ByteArray.
  *
  * If the byte offset is out of bounds, an error occurs.
  *
@@ skipping 1109 matching lines @@
  *
  * \param object An object.
  * \param peer A value to store in the peer field.
  *
  * \return Returns an error if 'object' is a subtype of Null, num, or
  *   bool.
  */
 DART_EXPORT Dart_Handle Dart_SetPeer(Dart_Handle object, void* peer);
 
 #endif  // INCLUDE_DART_API_H_