Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4355)

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 11362003: Make app windows restore position even if bounds are explicitly specified. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index 953eb6af8368ccb73baa73e59a159b8580e0cc53..a750ba26775d1e7945ff35bd774ea526487576f7 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -72,7 +72,6 @@ void SuspendRenderViewHost(RenderViewHost* rvh) {
ShellWindow::CreateParams::CreateParams()
: frame(ShellWindow::CreateParams::FRAME_CHROME),
bounds(INT_MIN, INT_MIN, INT_MIN, INT_MIN),
- restore_position(true), restore_size(true),
creator_process_id(0), hidden(false) {
}
@@ -128,19 +127,13 @@ void ShellWindow::Init(const GURL& url,
if (!params.window_key.empty()) {
window_key_ = params.window_key;
- if (params.restore_position || params.restore_size) {
- extensions::ShellWindowGeometryCache* cache =
- extensions::ExtensionSystem::Get(profile())->
- shell_window_geometry_cache();
- gfx::Rect cached_bounds;
- if (cache->GetGeometry(extension()->id(), params.window_key,
- &cached_bounds)) {
- if (params.restore_position)
- bounds.set_origin(cached_bounds.origin());
- if (params.restore_size)
- bounds.set_size(cached_bounds.size());
- }
- }
+ extensions::ShellWindowGeometryCache* cache =
+ extensions::ExtensionSystem::Get(profile())->
+ shell_window_geometry_cache();
+ gfx::Rect cached_bounds;
+ if (cache->GetGeometry(extension()->id(), params.window_key,
+ &cached_bounds))
+ bounds = cached_bounds;
}
ShellWindow::CreateParams new_params = params;

Powered by Google App Engine
This is Rietveld 408576698