Make app windows restore position even if bounds are explicitly specified.

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "base/command_line.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/debugger/devtools_window.h"
@@ skipping 94 matching lines @@
       // TODO(mek): use URL if no id specified?
       // Limit length of id to 256 characters.
       if (options->id->length() > 256) {
         error_ = app_window_constants::kInvalidWindowId;
         return false;
       }
 
       create_params.window_key = *options->id;
     }
 
+    // TODO(jeremya): remove these, since they do the same thing as
+    // left/top/width/height.
     if (options->default_width.get())
       create_params.bounds.set_width(*options->default_width.get());
     if (options->default_height.get())
       create_params.bounds.set_height(*options->default_height.get());
     if (options->default_left.get())
       create_params.bounds.set_x(*options->default_left.get());
     if (options->default_top.get())
       create_params.bounds.set_y(*options->default_top.get());
 
-
     if (options->width.get() || options->height.get()) {

[Marijn Kruisselbrink, 2012/11/12 17:56:51]

nit: With the restore_size bit gone, there is no reason to keep this if wrapping
the width/height getting.

       if (options->width.get())
         create_params.bounds.set_width(*options->width.get());
       if (options->height.get())
         create_params.bounds.set_height(*options->height.get());
-      create_params.restore_size = false;
     }
 
     if (options->left.get() || options->top.get()) {

[Marijn Kruisselbrink, 2012/11/12 17:56:51]

same here, this outer if no longer has a purpose

       if (options->left.get())
         create_params.bounds.set_x(*options->left.get());
       if (options->top.get())
         create_params.bounds.set_y(*options->top.get());
-      create_params.restore_position = false;
     }
 
     if (options->frame.get()) {
       if (*options->frame == kHtmlFrameOption &&
           CommandLine::ForCurrentProcess()->HasSwitch(
               switches::kEnableExperimentalExtensionApis)) {
         create_params.frame = ShellWindow::CreateParams::FRAME_NONE;
         inject_html_titlebar = true;
       } else if (*options->frame == kNoneFrameOption) {
         create_params.frame = ShellWindow::CreateParams::FRAME_NONE;
@@ skipping 59 matching lines @@
   if (ShellWindowRegistry::Get(profile())->HadDevToolsAttached(created_view)) {
     new DevToolsRestorer(this, created_view);
     return true;
   }
 
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions