webkit/media/android/webmediaplayer_manager_android.h - Issue 11361239: Keep playing audio even when opening another tab, going to another app etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/android/webmediaplayer_manager_android.h

Issue 11361239: Keep playing audio even when opening another tab, going to another app etc. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_view_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | webkit/media/android/webmediaplayer_manager_android.cc » ('j') | webkit/media/android/webmediaplayer_manager_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/media/android/webmediaplayer_manager_android.h

diff --git a/webkit/media/android/webmediaplayer_manager_android.h b/webkit/media/android/webmediaplayer_manager_android.h

index 1e959a0fc25dd348b8858c97ee37c1047f5aff24..f0312eed1061e53c59b6eef8ac502298491d1f60 100644

--- a/webkit/media/android/webmediaplayer_manager_android.h

+++ b/webkit/media/android/webmediaplayer_manager_android.h

@@ -28,8 +28,9 @@ class WebMediaPlayerManagerAndroid {

int RegisterMediaPlayer(WebMediaPlayerAndroid* player);

void UnregisterMediaPlayer(int player_id);

- // Release all the media resources managed by this object.

- void ReleaseMediaResources();

+ // Release all the media resources managed by this object unless

+ // an audio play is in progress.

qinmin 2012/11/14 18:14:29 not "audio", but ”media“, the logic should also ap

Miguel Garcia 2012/11/14 18:50:32 Well I thought that if the media happened to be vi

+ void ReleaseMediaResourcesIfNotPlaying();

// Check whether a player can enter fullscreen.

bool CanEnterFullscreen(WebKit::WebFrame* frame);