Keep playing audio even when opening another tab, going to another app etc.

webkit/media/android/webmediaplayer_manager_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/android/webmediaplayer_manager_android.h"
 
 #include "webkit/media/android/webmediaplayer_android.h"
 
 namespace webkit_media {
 
 WebMediaPlayerManagerAndroid::WebMediaPlayerManagerAndroid()
     : next_media_player_id_(0),
       fullscreen_frame_(NULL) {
 }
 
 WebMediaPlayerManagerAndroid::~WebMediaPlayerManagerAndroid() {
 }
 
 int WebMediaPlayerManagerAndroid::RegisterMediaPlayer(
     WebMediaPlayerAndroid* player) {
   media_players_[next_media_player_id_] = player;
   return next_media_player_id_++;
 }
 
 void WebMediaPlayerManagerAndroid::UnregisterMediaPlayer(int player_id) {
   media_players_.erase(player_id);
 }
 
-void WebMediaPlayerManagerAndroid::ReleaseMediaResources() {
+void WebMediaPlayerManagerAndroid::ReleaseMediaResourcesIfNotPlaying() {
   std::map<int32, WebMediaPlayerAndroid*>::iterator player_it;
   for (player_it = media_players_.begin();
       player_it != media_players_.end(); ++player_it) {
-    (player_it->second)->ReleaseMediaResources();
+    WebMediaPlayerAndroid* player = player_it->second;
+    DCHECK(player);

[qinmin, 2012/11/14 18:14:29]

useless DCHECK

[Miguel Garcia, 2012/11/14 18:50:32]

removed

+
+    // Do not release if an audio track is still playing
+    if (player && (!player->hasAudio() || player->paused()))

[qinmin, 2012/11/14 18:14:29]

hasAudio() always return true on android. Even on desktop, it only checks the
current frame. You can remove it here. 

[Miguel Garcia, 2012/11/14 18:50:32]

Removed

On 2012/11/14 18:14:29, qinmin wrote:

+      player->ReleaseMediaResources();
   }
 }
 
 WebMediaPlayerAndroid* WebMediaPlayerManagerAndroid::GetMediaPlayer(
     int player_id) {
   std::map<int32, WebMediaPlayerAndroid*>::iterator iter =
       media_players_.find(player_id);
   if (iter != media_players_.end())
     return iter->second;
   return NULL;
 }
 
 bool WebMediaPlayerManagerAndroid::CanEnterFullscreen(WebKit::WebFrame* frame) {
   return !fullscreen_frame_ || IsInFullscreen(frame);
 }
 
 void WebMediaPlayerManagerAndroid::DidEnterFullscreen(WebKit::WebFrame* frame) {
   fullscreen_frame_ = frame;
 }
 
 void WebMediaPlayerManagerAndroid::DidExitFullscreen() {
   fullscreen_frame_ = NULL;
 }
 
 bool WebMediaPlayerManagerAndroid::IsInFullscreen(WebKit::WebFrame* frame) {
   return fullscreen_frame_ == frame;
 }
 
 }  // namespace webkit_media