Extends IBusObject to handle attachment field.

chromeos/dbus/ibus/ibus_lookup_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/ibus/ibus_lookup_table.h"
 
 #include <string>
 #include "base/logging.h"
+#include "base/values.h"
+#include "chromeos/dbus/ibus/ibus_object.h"
+#include "chromeos/dbus/ibus/ibus_text.h"
 #include "dbus/message.h"
-#include "chromeos/dbus/ibus/ibus_text.h"
-#include "chromeos/dbus/ibus/ibus_object.h"
 
 namespace chromeos {
 // TODO(nona): Remove ibus namespace after complete libibus removal.
 namespace ibus {
 
 namespace {
 // The default entry number of a page in IBusLookupTable.
 const int kDefaultPageSize = 9;
+const char kShowWindowAtCompositionKey[] = "show_window_at_composition";
 }  // namespace
 
 void AppendIBusLookupTable(const IBusLookupTable& table,
                            dbus::MessageWriter* writer) {
   IBusObjectWriter ibus_lookup_table_writer("IBusLookupTable",
                                             "uubbiavav",
                                             writer);
+  scoped_ptr<base::Value> show_position(
+      base::Value::CreateBooleanValue(table.show_window_at_composition()));
+  ibus_lookup_table_writer.AddAttachment(kShowWindowAtCompositionKey,
+                                         *show_position.get());
+  ibus_lookup_table_writer.CloseHeader();
   ibus_lookup_table_writer.AppendUint32(table.page_size());
   ibus_lookup_table_writer.AppendUint32(table.cursor_position());
   ibus_lookup_table_writer.AppendBool(table.is_cursor_visible());
   ibus_lookup_table_writer.AppendBool(false);  // Not used in Chrome.
   ibus_lookup_table_writer.AppendInt32(static_cast<int32>(table.orientation()));
 
   const std::vector<IBusLookupTable::Entry>& candidates = table.candidates();
   dbus::MessageWriter text_writer(NULL);
   ibus_lookup_table_writer.OpenArray("v", &text_writer);
   bool have_labels = false;
@@ skipping 16 matching lines @@
     }
   }
   ibus_lookup_table_writer.CloseContainer(&label_writer);
 
   ibus_lookup_table_writer.CloseAll();
 }
 
 bool PopIBusLookupTable(dbus::MessageReader* reader, IBusLookupTable* table) {
   IBusObjectReader ibus_object_reader("IBusLookupTable", reader);
 
-  dbus::MessageReader attachment_reader(NULL);
-  if (!ibus_object_reader.InitWithAttachmentReader(&attachment_reader))
+  if (!ibus_object_reader.Init())
     return false;
 
-  while (attachment_reader.HasMoreData()) {
-    dbus::MessageReader dictionary_reader(NULL);
-    if (!attachment_reader.PopDictEntry(&dictionary_reader)) {
-      LOG(ERROR) << "Invalid attachment structure: "
-                 << "The attachment field is array of dictionary entry.";
-      return false;
-    }
-
-    std::string key;
-    if (!dictionary_reader.PopString(&key)) {
-      LOG(ERROR) << "Invalid attachement structure: "
-                 << "The 1st dictionary entry should be string.";
-      return false;
-    }
-    if (key != "show_window_at_composition")
-      continue;
-
-    dbus::MessageReader variant_reader(NULL);
-    if (!dictionary_reader.PopVariant(&variant_reader)) {
-      LOG(ERROR) << "Invalid attachment structure: "
-                 << "The 2nd dictionary entry shuold be variant.";
-      return false;
-    }
-
-    dbus::MessageReader sub_variant_reader(NULL);
-    if (!variant_reader.PopVariant(&sub_variant_reader)) {
-      LOG(ERROR) << "Invalid attachment structure: "
-                 << "The 2nd variant entry should contain variant.";
-      return false;
-    }
-
-    bool show_window_at_composition = false;
-    if (!sub_variant_reader.PopBool(&show_window_at_composition))
-      continue;  // Ignores other field.
-
-    table->set_show_window_at_composition(show_window_at_composition);
+  base::Value* value;
+  if (ibus_object_reader.GetAttachment(kShowWindowAtCompositionKey, &value)) {
+    bool show_window_at_composition;
+    if (value->GetAsBoolean(&show_window_at_composition))
+      table->set_show_window_at_composition(show_window_at_composition);
   }
 
   uint32 page_size = 0;
   if (!ibus_object_reader.PopUint32(&page_size)) {
     LOG(ERROR) << "Invalid variant structure[IBusLookupTable]: "
                << "1st argument should be uint32.";
     return false;
   }
   table->set_page_size(page_size);
 
@@ skipping 82 matching lines @@
   }
   return true;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // IBusLookupTable
 IBusLookupTable::IBusLookupTable()
     : page_size_(kDefaultPageSize),
       cursor_position_(0),
       is_cursor_visible_(true),
-      orientation_(IBUS_LOOKUP_TABLE_ORIENTATION_HORIZONTAL) {
+      orientation_(IBUS_LOOKUP_TABLE_ORIENTATION_HORIZONTAL),
+      show_window_at_composition_(false) {
 }
 
 IBusLookupTable::~IBusLookupTable() {
 }
 
 IBusLookupTable::Entry::Entry() {
 }
 
 IBusLookupTable::Entry::~Entry() {
 }
 
 }  // namespace ibus
 }  // namespace chromeos