Extends IBusObject to handle attachment field.

Extends IBusObject to handle attachment field.

With this CL, IBusObjectReader/IBusObjectWriter can read/write attachment field in IBusObject header field.

BUG=140186
TEST=ran chromeos_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168522

[satorux1, 2012-11-13 04:37:37]

http://codereview.chromium.org/11361210/diff/2001/chromeos/dbus/ibus/ibus_obj...
File chromeos/dbus/ibus/ibus_object.h (right):

http://codereview.chromium.org/11361210/diff/2001/chromeos/dbus/ibus/ibus_obj...
chromeos/dbus/ibus/ibus_object.h:142: bool GetAttachment(const std::string& key,
base::Value** value);
What about returning a "const base::Value*". We can return NULL if the entry is
not found.

[Seigo Nonaka, 2012-11-13 06:22:17]

http://codereview.chromium.org/11361210/diff/2001/chromeos/dbus/ibus/ibus_obj...
File chromeos/dbus/ibus/ibus_object.h (right):

http://codereview.chromium.org/11361210/diff/2001/chromeos/dbus/ibus/ibus_obj...
chromeos/dbus/ibus/ibus_object.h:142: bool GetAttachment(const std::string& key,
base::Value** value);
On 2012/11/13 04:37:37, satorux1 wrote:
> What about returning a "const base::Value*". We can return NULL if the entry
is
> not found.

Done.

[Seigo Nonaka, 2012-11-19 06:19:32]

ping? just in case.

[satorux1, 2012-11-19 07:08:46]

LGTM. Please feel free to ping me more aggressively.

[Seigo Nonaka, 2012-11-19 08:26:15]

Sure, thanks.

[commit-bot: I haz the power, 2012-11-19 08:26:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11361210/6001

[commit-bot: I haz the power, 2012-11-19 08:26:42]

Presubmit check for 11361210-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Your #include order seems to be broken. Send mail to
marja@chromium.org if this is not the case.
      chromeos/dbus/ibus/ibus_object.h:9

Presubmit checks took 1.3s to calculate.

[commit-bot: I haz the power, 2012-11-19 08:29:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11361210/17001

[commit-bot: I haz the power, 2012-11-19 08:35:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-19 09:23:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11361210/17001

[commit-bot: I haz the power, 2012-11-19 09:26:21]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_rel_device.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-19 13:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/11361210/17001

[commit-bot: I haz the power, 2012-11-19 15:17:30]

Change committed as 168522