When building standalone Dart executable, put implementation of dart:io natives in a separate libra…

runtime/bin/bin.gypi

Index: runtime/bin/bin.gypi
diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi
index 3cde1ee1bf67c861a87526da133c6ff97c39aa32..a6be495e45e4eab29663afe482c63e327b800066 100644
--- a/runtime/bin/bin.gypi
+++ b/runtime/bin/bin.gypi
@@ -267,6 +267,7 @@
       'sources': [
         'builtin_natives.cc',
         'builtin.h',
+        'io_natives.h',
       ],
       'includes': [
         'builtin_impl_sources.gypi',
@@ -303,6 +304,38 @@
       ],
     },
     {
+      'target_name': 'libdart_io',
+      'type': 'static_library',
+      'dependencies': [

[Mads Ager (google), 2012/11/08 09:32:26]

Can you leave this out since it is empty?

+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'io_natives.h',
+        'io_natives.cc',
+      ],
+      'includes': [
+        'io_impl_sources.gypi',
+      ],
+      'conditions': [
+        ['OS=="win"', {
+          # TODO(antonm): fix the implementation.
+          # Current implementation accepts char* strings
+          # and therefore fails to compile once _UNICODE is
+          # enabled.  That should be addressed using -A
+          # versions of functions and adding necessary conversions.
+          'configurations': {
+            'Common_Base': {
+              'msvs_configuration_attributes': {
+                'CharacterSet': '0',
+              },
+            },
+          },
+        }],
+      ],
+    },
+    {
       'target_name': 'libdart_withcore',
       'type': 'static_library',
       'dependencies': [
@@ -339,6 +372,7 @@
       ],
       'sources': [
         'gen_snapshot.cc',
+        # Only looks up native functions in libdart_builtin, not libdart_io.
         'builtin.cc',
         # Include generated source files.
         '<(builtin_cc_file)',
@@ -422,6 +456,7 @@
         'libdart_export',
         'libdart_builtin',
         'generate_snapshot_file',
+        'libdart_io',

[Mads Ager (google), 2012/11/08 09:32:26]

Move this up to after libdart_builtin and leave generate_snapshot_file as the
last one?

       ],
       'include_dirs': [
         '..',
@@ -453,13 +488,14 @@
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
+        'libdart_io',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'main.cc',
-        'builtin.cc',
+        'builtin_fulllib.cc',
         # Include generated source files.
         '<(builtin_cc_file)',
         '<(crypto_cc_file)',
@@ -497,6 +533,7 @@
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
+        'libdart_io',
         'generate_snapshot_test_dat_file',
       ],
       'include_dirs': [
@@ -505,7 +542,7 @@
       ],
       'sources': [
         'run_vm_tests.cc',
-        'builtin.cc',
+        'builtin_fulllib.cc',

[Mads Ager (google), 2012/11/08 09:32:26]

Would it be better to do the naming the other way around.

builtin.cc remains the one that has everything.
builtin_nolib.cc remains the one that has everything but no source code.
builtin_gen_snapshot.cc is the new one which has only the stuff needed for
snapshot generation.

         # Include generated source files.
         '<(builtin_cc_file)',
         '<(crypto_cc_file)',
@@ -527,7 +564,7 @@
       'sources/': [
         ['exclude', '\\.(cc|h)$'],
         ['include', 'run_vm_tests.cc'],
-        ['include', 'builtin.cc'],
+        ['include', 'builtin_fulllib.cc'],
         ['include', '_gen\\.cc$'],
         ['include', '_test\\.(cc|h)$'],
       ],