When building standalone Dart executable, put implementation of dart:io natives in a separate libra…

runtime/bin/bin.gypi

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 {
   'variables': {
     'crypto_cc_file': '<(SHARED_INTERMEDIATE_DIR)/crypto_gen.cc',
     'io_cc_file': '<(SHARED_INTERMEDIATE_DIR)/io_gen.cc',
     'io_patch_cc_file': '<(SHARED_INTERMEDIATE_DIR)/io_patch_gen.cc',
     'json_cc_file': '<(SHARED_INTERMEDIATE_DIR)/json_gen.cc',
@@ skipping 249 matching lines @@
         'generate_json_cc_file',
         'generate_uri_cc_file',
         'generate_utf_cc_file',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'builtin_natives.cc',
         'builtin.h',
+        'io_natives.h',
       ],
       'includes': [
         'builtin_impl_sources.gypi',
         '../platform/platform_sources.gypi',
       ],
       'sources/': [
         ['exclude', '_test\\.(cc|h)$'],
       ],
       'conditions': [
         ['OS=="win"', {
@@ skipping 16 matching lines @@
         ['OS=="linux"', {
           'link_settings': {
             'libraries': [
               '-ldl',
             ],
           },
         }],
       ],
     },
     {
+      'target_name': 'libdart_io',
+      'type': 'static_library',
+      'dependencies': [

[Mads Ager (google), 2012/11/08 09:32:26]

Can you leave this out since it is empty?

+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'io_natives.h',
+        'io_natives.cc',
+      ],
+      'includes': [
+        'io_impl_sources.gypi',
+      ],
+      'conditions': [
+        ['OS=="win"', {
+          # TODO(antonm): fix the implementation.
+          # Current implementation accepts char* strings
+          # and therefore fails to compile once _UNICODE is
+          # enabled.  That should be addressed using -A
+          # versions of functions and adding necessary conversions.
+          'configurations': {
+            'Common_Base': {
+              'msvs_configuration_attributes': {
+                'CharacterSet': '0',
+              },
+            },
+          },
+        }],
+      ],
+    },
+    {
       'target_name': 'libdart_withcore',
       'type': 'static_library',
       'dependencies': [
         'libdart_lib_withcore',
         'libdart_vm',
         'libjscre',
         'libdouble_conversion',
         'generate_version_cc_file',
       ],
       'include_dirs': [
@@ skipping 16 matching lines @@
       'type': 'executable',
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'gen_snapshot.cc',
+        # Only looks up native functions in libdart_builtin, not libdart_io.
         'builtin.cc',
         # Include generated source files.
         '<(builtin_cc_file)',
         '<(crypto_cc_file)',
         '<(io_cc_file)',
         '<(io_patch_cc_file)',
         '<(json_cc_file)',
         '<(uri_cc_file)',
         '<(utf_cc_file)',
       ],
@@ skipping 63 matching lines @@
       ]
     },
     {
       # dart binary with a snapshot of corelibs built in.
       'target_name': 'dart',
       'type': 'executable',
       'dependencies': [
         'libdart_export',
         'libdart_builtin',
         'generate_snapshot_file',
+        'libdart_io',

[Mads Ager (google), 2012/11/08 09:32:26]

Move this up to after libdart_builtin and leave generate_snapshot_file as the
last one?

       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'main.cc',
         'builtin_nolib.cc',
         '<(snapshot_cc_file)',
       ],
       'conditions': [
@@ skipping 11 matching lines @@
         }],
        ],
     },
     {
       # dart binary without any snapshot built in.
       'target_name': 'dart_no_snapshot',
       'type': 'executable',
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
+        'libdart_io',
       ],
       'include_dirs': [
         '..',
       ],
       'sources': [
         'main.cc',
-        'builtin.cc',
+        'builtin_fulllib.cc',
         # Include generated source files.
         '<(builtin_cc_file)',
         '<(crypto_cc_file)',
         '<(io_cc_file)',
         '<(io_patch_cc_file)',
         '<(json_cc_file)',
         '<(uri_cc_file)',
         '<(utf_cc_file)',
         'snapshot_empty.cc',
       ],
@@ skipping 17 matching lines @@
       'sources': [
         'process_test.cc',
       ]
     },
     {
       'target_name': 'run_vm_tests',
       'type': 'executable',
       'dependencies': [
         'libdart_withcore',
         'libdart_builtin',
+        'libdart_io',
         'generate_snapshot_test_dat_file',
       ],
       'include_dirs': [
         '..',
         '<(SHARED_INTERMEDIATE_DIR)',
       ],
       'sources': [
         'run_vm_tests.cc',
-        'builtin.cc',
+        'builtin_fulllib.cc',

[Mads Ager (google), 2012/11/08 09:32:26]

Would it be better to do the naming the other way around.

builtin.cc remains the one that has everything.
builtin_nolib.cc remains the one that has everything but no source code.
builtin_gen_snapshot.cc is the new one which has only the stuff needed for
snapshot generation.

         # Include generated source files.
         '<(builtin_cc_file)',
         '<(crypto_cc_file)',
         '<(io_cc_file)',
         '<(io_patch_cc_file)',
         '<(json_cc_file)',
         '<(uri_cc_file)',
         '<(utf_cc_file)',
       ],
       'includes': [
         'builtin_impl_sources.gypi',
         '../platform/platform_sources.gypi',
         '../vm/vm_sources.gypi',
       ],
       'defines': [
         'TESTING',
       ],
       # Only include _test.[cc|h] files.
       'sources/': [
         ['exclude', '\\.(cc|h)$'],
         ['include', 'run_vm_tests.cc'],
-        ['include', 'builtin.cc'],
+        ['include', 'builtin_fulllib.cc'],
         ['include', '_gen\\.cc$'],
         ['include', '_test\\.(cc|h)$'],
       ],
       'conditions': [
         ['OS=="win"', {
           'link_settings': {
             'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ],
           },
         }],
       ],
@@ skipping 27 matching lines @@
         ['OS=="mac"', {
           'xcode_settings': {
             'OTHER_LDFLAGS': [ '-undefined', 'dynamic_lookup' ],
           },
         }],
       ],
     },
   ],
 }