Pass closure object as first implicit argument to closure functions.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 3918 matching lines @@
   return Api::NewError("Exception was not re thrown, internal error");
 }
 
 
 // --- Native functions ---
 
 
 DART_EXPORT Dart_Handle Dart_GetNativeArgument(Dart_NativeArguments args,
                                                int index) {
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
+  const bool is_instance = arguments->AreOfInstanceFunction();
+  const bool is_closure = arguments->AreOfClosureFunction();
+  if (!is_instance && is_closure) {
+    index++;  // Hide closure object.

[siva, 2012/11/07 18:56:32]

This seems to suggest that if one passed in an index of -1
to this function and the arguments are for a static implicit closure then we
will not be reporting an error.

Maybe you should increment the index after the index check
below?

[regis, 2012/11/08 18:08:30]

Good catch! Incrementing the index after the check would require the upper bound
to be adjusted prior to the check. It is actually simpler to use
Dart_GetNativeArgumentCount here.

+  }
   if (index < 0 || index >= arguments->Count()) {
     return Api::NewError(
         "%s: argument 'index' out of range. Expected 0..%d but saw %d.",
         CURRENT_FUNC, arguments->Count() - 1, index);
   }
   Isolate* isolate = arguments->isolate();
   CHECK_ISOLATE(isolate);
-  return Api::NewHandle(isolate, arguments->At(index));
+  if ((index == 0) && is_instance && is_closure) {
+    // Retrieve the receiver from the context.
+    const Context& context = Context::Handle(isolate->top_context());
+    return Api::NewHandle(isolate, context.At(0));
+  } else {
+    return Api::NewHandle(isolate, arguments->At(index));
+  }
 }
 
 
 DART_EXPORT int Dart_GetNativeArgumentCount(Dart_NativeArguments args) {
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
-  return arguments->Count();
+  int count = arguments->Count();
+  if (arguments->AreOfClosureFunction() &&
+      !arguments->AreOfInstanceFunction()) {
+    // The closure at index 0 is hidden and therefore not counted.
+    count--;
+    // In the instance closure function case, the receiver is accessed from
+    // the context and the closure at index 0 is hidden, so the apparent
+    // argument count remains unchanged.

[siva, 2012/11/07 18:56:32]

This comment should appear outside the if statement right.

[regis, 2012/11/08 18:08:30]

Done.

+  }
+  return count;
 }
 
 
 // This function has friend access to SetReturnUnsafe.
 void SetReturnValueHelper(Dart_NativeArguments args, Dart_Handle retval) {
   NoGCScope no_gc_scope;
   NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
   arguments->SetReturnUnsafe(Api::UnwrapHandle(retval));
 }
 
@@ skipping 481 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success(isolate);
 }
 
 }  // namespace dart