Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: media/filters/ffmpeg_video_decoder_unittest.cc

Issue 11359100: Add RunCallback to invoke a callback parameter in unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/decrypting_video_decoder_unittest.cc ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_video_decoder_unittest.cc
diff --git a/media/filters/ffmpeg_video_decoder_unittest.cc b/media/filters/ffmpeg_video_decoder_unittest.cc
index 9d9c24d1c38725118cc5a41dbf7162d4d7d0ccd7..b97f7b3c9a2541c7c8edecf6aa1309f8359a327c 100644
--- a/media/filters/ffmpeg_video_decoder_unittest.cc
+++ b/media/filters/ffmpeg_video_decoder_unittest.cc
@@ -12,6 +12,7 @@
#include "base/string_util.h"
#include "media/base/decoder_buffer.h"
#include "media/base/decrypt_config.h"
+#include "media/base/gmock_callback_support.h"
#include "media/base/limits.h"
#include "media/base/mock_callback.h"
#include "media/base/mock_filters.h"
@@ -62,10 +63,6 @@ ACTION_P(ReturnBuffer, buffer) {
arg0.Run(buffer ? DemuxerStream::kOk : DemuxerStream::kAborted, buffer);
}
-ACTION_P2(RunDecryptCB, status, buffer) {
- arg2.Run(status, buffer);
-}
-
class FFmpegVideoDecoderTest : public testing::Test {
public:
FFmpegVideoDecoderTest()
@@ -469,7 +466,7 @@ TEST_F(FFmpegVideoDecoderTest, DecodeEncryptedFrame_Normal) {
// Simulate decoding a single encrypted frame.
EXPECT_CALL(*decryptor_,
Decrypt(Decryptor::kVideo, encrypted_i_frame_buffer_, _))
- .WillRepeatedly(RunDecryptCB(Decryptor::kSuccess, i_frame_buffer_));
+ .WillRepeatedly(RunCallback<2>(Decryptor::kSuccess, i_frame_buffer_));
VideoDecoder::Status status;
scoped_refptr<VideoFrame> video_frame;
@@ -489,8 +486,8 @@ TEST_F(FFmpegVideoDecoderTest, DecodeEncryptedFrame_DecryptError) {
.WillRepeatedly(ReturnBuffer(encrypted_i_frame_buffer_));
EXPECT_CALL(*decryptor_,
Decrypt(Decryptor::kVideo, encrypted_i_frame_buffer_, _))
- .WillRepeatedly(RunDecryptCB(Decryptor::kError,
- scoped_refptr<media::DecoderBuffer>()));
+ .WillRepeatedly(RunCallback<2>(Decryptor::kError,
+ scoped_refptr<media::DecoderBuffer>()));
// Our read should still get satisfied with end of stream frame during an
// error.
@@ -512,8 +509,8 @@ TEST_F(FFmpegVideoDecoderTest, DecodeEncryptedFrame_NoDecryptionKey) {
.WillRepeatedly(ReturnBuffer(encrypted_i_frame_buffer_));
EXPECT_CALL(*decryptor_,
Decrypt(Decryptor::kVideo, encrypted_i_frame_buffer_, _))
- .WillRepeatedly(RunDecryptCB(Decryptor::kNoKey,
- scoped_refptr<media::DecoderBuffer>()));
+ .WillRepeatedly(RunCallback<2>(Decryptor::kNoKey,
+ scoped_refptr<media::DecoderBuffer>()));
// Our read should still get satisfied with end of stream frame during an
// error.
@@ -536,8 +533,8 @@ TEST_F(FFmpegVideoDecoderTest, DecodeEncryptedFrame_CorruptedBufferReturned) {
.WillRepeatedly(ReturnBuffer(encrypted_i_frame_buffer_));
EXPECT_CALL(*decryptor_,
Decrypt(Decryptor::kVideo, encrypted_i_frame_buffer_, _))
- .WillRepeatedly(RunDecryptCB(Decryptor::kSuccess,
- corrupt_i_frame_buffer_));
+ .WillRepeatedly(RunCallback<2>(Decryptor::kSuccess,
+ corrupt_i_frame_buffer_));
// The decoder only detects the error at the second decoding call. So
// |statistics_cb_| still gets called once.
EXPECT_CALL(statistics_cb_, OnStatistics(_));
« no previous file with comments | « media/filters/decrypting_video_decoder_unittest.cc ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698