Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: media/filters/audio_renderer_impl_unittest.cc

Issue 11359100: Add RunCallback to invoke a callback parameter in unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/decrypting_audio_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_impl_unittest.cc
diff --git a/media/filters/audio_renderer_impl_unittest.cc b/media/filters/audio_renderer_impl_unittest.cc
index dff17330c98b1b6111e5ea08522ed68e084cdd2d..cfc31449fb44ddf947c0553c5274f3f7bb000a78 100644
--- a/media/filters/audio_renderer_impl_unittest.cc
+++ b/media/filters/audio_renderer_impl_unittest.cc
@@ -8,6 +8,7 @@
#include "base/message_loop.h"
#include "base/stl_util.h"
#include "media/base/data_buffer.h"
+#include "media/base/gmock_callback_support.h"
#include "media/base/mock_audio_renderer_sink.h"
#include "media/base/mock_callback.h"
#include "media/base/mock_filters.h"
@@ -21,10 +22,6 @@ using ::testing::Return;
using ::testing::NiceMock;
using ::testing::StrictMock;
-ACTION_P(RunPipelineStatusCB1, status) {
- arg1.Run(status);
-}
-
namespace media {
// Constants for distinguishing between muted audio and playing audio when using
@@ -100,7 +97,7 @@ class AudioRendererImplTest : public ::testing::Test {
void Initialize() {
EXPECT_CALL(*decoder_, Initialize(_, _, _))
- .WillOnce(RunPipelineStatusCB1(PIPELINE_OK));
+ .WillOnce(RunCallback<1>(PIPELINE_OK));
InitializeWithStatus(PIPELINE_OK);
message_loop_.RunUntilIdle();
@@ -246,7 +243,7 @@ class AudioRendererImplTest : public ::testing::Test {
TEST_F(AudioRendererImplTest, Initialize_Failed) {
EXPECT_CALL(*decoder_, Initialize(_, _, _))
- .WillOnce(RunPipelineStatusCB1(PIPELINE_OK));
+ .WillOnce(RunCallback<1>(PIPELINE_OK));
SetUnsupportedAudioDecoderProperties();
InitializeWithStatus(PIPELINE_ERROR_INITIALIZATION_FAILED);
@@ -264,7 +261,7 @@ TEST_F(AudioRendererImplTest, Initialize_Successful) {
TEST_F(AudioRendererImplTest, Initialize_DecoderInitFailure) {
EXPECT_CALL(*decoder_, Initialize(_, _, _))
- .WillOnce(RunPipelineStatusCB1(PIPELINE_ERROR_DECODE));
+ .WillOnce(RunCallback<1>(PIPELINE_ERROR_DECODE));
InitializeWithStatus(PIPELINE_ERROR_DECODE);
// We should have no reads.
@@ -276,9 +273,9 @@ TEST_F(AudioRendererImplTest, Initialize_MultipleDecoders) {
// Insert |decoder1| as the first decoder in the list.
decoders_.push_front(decoder1);
EXPECT_CALL(*decoder1, Initialize(_, _, _))
- .WillOnce(RunPipelineStatusCB1(DECODER_ERROR_NOT_SUPPORTED));
+ .WillOnce(RunCallback<1>(DECODER_ERROR_NOT_SUPPORTED));
EXPECT_CALL(*decoder_, Initialize(_, _, _))
- .WillOnce(RunPipelineStatusCB1(PIPELINE_OK));
+ .WillOnce(RunCallback<1>(PIPELINE_OK));
InitializeWithStatus(PIPELINE_OK);
// We should have no reads.
« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/decrypting_audio_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698