Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 113591: Fix Acid3 Test 48: LINKTEST, Chromium side.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Made waiting more bearable. Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/browser_render_process_host.cc
===================================================================
--- chrome/browser/renderer_host/browser_render_process_host.cc (revision 19822)
+++ chrome/browser/renderer_host/browser_render_process_host.cc (working copy)
@@ -123,6 +123,62 @@
RenderProcess* render_process_;
};
+
+// Size of the buffer after which individual link updates deemed not warranted
+// and the overall update should be used instead.
+static const unsigned kVisitedLinkBufferThreshold = 50;
+
+// This class manages buffering and sending visited link hashes (fingerprints)
+// to renderer based on widget visibility.
+// As opposed to the VisitedLinkEventListener in profile.cc, which coalesces to
+// reduce the rate of messages being send to render processes, this class
+// ensures that the updates occur only when explicitly requested. This is
+// used by BrowserRenderProcessHost to only send Add/Reset link events to the
+// renderers when their tabs are visible.
+class VisitedLinkUpdater {
+ public:
+ VisitedLinkUpdater() : threshold_reached_(false) {}
+
+ void Buffer(const VisitedLinkCommon::Fingerprints& links) {
+ if (threshold_reached_)
+ return;
+
+ if (pending_.size() + links.size() > kVisitedLinkBufferThreshold) {
+ threshold_reached_ = true;
+ // Once the threshold is reached, there's no need to store pending visited
+ // links.
+ pending_.clear();
+ return;
+ }
+
+ pending_.insert(pending_.end(), links.begin(), links.end());
+ }
+
+ void Clear() {
+ pending_.clear();
+ }
+
+ void Update(IPC::Channel::Sender* sender) {
+ if (threshold_reached_) {
+ sender->Send(new ViewMsg_VisitedLink_Reset());
+ threshold_reached_ = false;
+ return;
+ }
+
+ if (pending_.size() == 0)
+ return;
+
+ sender->Send(new ViewMsg_VisitedLink_Add(pending_));
+
+ pending_.clear();
+ }
+
+ private:
+ bool threshold_reached_;
+ VisitedLinkCommon::Fingerprints pending_;
+};
+
+
// Used for a View_ID where the renderer has not been attached yet
const int32 kInvalidViewID = -1;
@@ -155,6 +211,8 @@
SetProcessID(next_pid);
}
+ visited_link_updater_.reset(new VisitedLinkUpdater());
+
// Note: When we create the BrowserRenderProcessHost, it's technically
// backgrounded, because it has no visible listeners. But the process
// doesn't actually exist yet, so we'll Background it later, after
@@ -456,6 +514,7 @@
// Verify we were properly backgrounded.
DCHECK(backgrounded_ == (visible_widgets_ == 0));
visible_widgets_++;
+ visited_link_updater_->Update(this);
SetBackgrounded(false);
}
@@ -487,6 +546,20 @@
#endif // !defined(OS_WIN)
}
+void BrowserRenderProcessHost::AddVisitedLinks(
+ const VisitedLinkCommon::Fingerprints& links) {
+ visited_link_updater_->Buffer(links);
+ if (visible_widgets_ == 0)
+ return;
+
+ visited_link_updater_->Update(this);
+}
+
+void BrowserRenderProcessHost::ResetVisitedLinks() {
+ visited_link_updater_->Clear();
+ Send(new ViewMsg_VisitedLink_Reset());
+}
+
base::ProcessHandle BrowserRenderProcessHost::GetRendererProcessHandle() {
if (run_renderer_in_process())
return base::Process::Current().handle();
« no previous file with comments | « chrome/browser/renderer_host/browser_render_process_host.h ('k') | chrome/browser/renderer_host/mock_render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698