Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 11359013: Adding App Launcher shortcuts on install. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install.cc ('k') | chrome/installer/util/chrome_app_host_distribution.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index d670288580e985278c87e2c19c7059ea50a26e67..5b14515cb7039d92d7ee32fe288b97ff79e42cf9 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -256,14 +256,9 @@ void CloseChromeFrameHelperProcess() {
}
}
-// This method deletes the product's shortcut folder from the
-// Windows Start menu. It checks system_uninstall to see if the shortcut is
-// in all users start menu or current user start menu.
-// We try to remove the standard desktop shortcut but if that fails we try
-// to remove the alternate desktop shortcut. Only one of them should be
-// present in a given install but at this point we don't know which one.
-// We remove all start screen secondary tiles by removing the folder Windows
-// uses to store this installation's tiles.
+// Deletes shortcuts at |install_level| from Start menu, Desktop,
+// Quick Launch, taskbar, and secondary tiles on the Start Screen (Win8+).
+// Only shortcuts pointing to |target| will be removed.
void DeleteShortcuts(const InstallerState& installer_state,
const Product& product,
const string16& target_exe) {
@@ -1053,10 +1048,10 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
}
}
- // Chrome is not in use so lets uninstall Chrome by deleting various files
- // and registry entries. Here we will just make best effort and keep going
- // in case of errors.
if (is_chrome) {
+ // Chrome is not in use so lets uninstall Chrome by deleting various files
+ // and registry entries. Here we will just make best effort and keep going
+ // in case of errors.
ClearRlzProductState();
// Delete the key that delegate_execute might make.
if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
@@ -1067,8 +1062,15 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
auto_launch_util::DisableAllAutoStartFeatures(
ASCIIToUTF16(chrome::kInitialProfile));
- // First delete shortcuts from Start->Programs, Desktop & Quick Launch.
DeleteShortcuts(installer_state, product, chrome_exe);
+
+ } else if (product.is_chrome_app_host()) {
+ // TODO(huangs): Remove this check once we have system-level App Host.
+ DCHECK(!installer_state.system_install());
+ const string16 app_host_exe(
+ installer_state.target_path().Append(installer::kChromeAppHostExe)
+ .value());
+ DeleteShortcuts(installer_state, product, app_host_exe);
}
// Delete the registry keys (Uninstall key and Version key).
« no previous file with comments | « chrome/installer/setup/install.cc ('k') | chrome/installer/util/chrome_app_host_distribution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698