Redesigned and refactored ScopedMTPDeviceMapEntry, MTPDeviceMapService & MTPDeviceDelegate classes.

webkit/fileapi/media/device_media_file_util.cc

Index: webkit/fileapi/media/device_media_file_util.cc
diff --git a/webkit/fileapi/media/device_media_file_util.cc b/webkit/fileapi/media/device_media_file_util.cc
index 6283bff5f4d449460a92c0507fa098bf3ade8ba8..eb4ede30fa5c88f1ab9c4c1ce585653573a7885a 100644
--- a/webkit/fileapi/media/device_media_file_util.cc
+++ b/webkit/fileapi/media/device_media_file_util.cc
@@ -63,7 +63,9 @@ PlatformFileError DeviceMediaFileUtil::GetFileInfo(
     const FileSystemURL& url,
     PlatformFileInfo* file_info,
     FilePath* platform_path) {
-  DCHECK(context->mtp_device_delegate());
+  if (!context->mtp_device_delegate().get())
+    return base::PLATFORM_FILE_ERROR_NOT_FOUND;
+
   PlatformFileError error =
       context->mtp_device_delegate()->GetFileInfo(url.path(), file_info);
   if (error != base::PLATFORM_FILE_OK)
@@ -80,7 +82,9 @@ scoped_ptr<FileSystemFileUtil::AbstractFileEnumerator>
         FileSystemOperationContext* context,
         const FileSystemURL& url,
         bool recursive) {
-  DCHECK(context->mtp_device_delegate());
+  if (!context->mtp_device_delegate().get())
+    return make_scoped_ptr(new FileSystemFileUtil::EmptyFileEnumerator())
+        .PassAs<FileSystemFileUtil::AbstractFileEnumerator>();
   return make_scoped_ptr(new FilteringFileEnumerator(
       context->mtp_device_delegate()->CreateFileEnumerator(url.path(),
                                                            recursive),
@@ -113,7 +117,9 @@ PlatformFileError DeviceMediaFileUtil::Truncate(
 bool DeviceMediaFileUtil::IsDirectoryEmpty(
     FileSystemOperationContext* context,
     const FileSystemURL& url) {
-  DCHECK(context->mtp_device_delegate());
+  if (!context->mtp_device_delegate().get())
+    return false;
+
   scoped_ptr<AbstractFileEnumerator> enumerator(
       CreateFileEnumerator(context, url, false));
   FilePath path;
@@ -161,7 +167,8 @@ base::PlatformFileError DeviceMediaFileUtil::CreateSnapshotFile(
   DCHECK(file_info);
   DCHECK(local_path);
   DCHECK(snapshot_policy);
-  DCHECK(context->mtp_device_delegate());
+  if (!context->mtp_device_delegate().get())
+    return base::PLATFORM_FILE_ERROR_FAILED;

[kinuko, 2012/11/15 10:23:39]

return base::PLATFORM_FILE_ERROR_NOT_FOUND ?

[kmadhusu, 2012/11/15 17:52:24]

Done.

 
   // We return a temporary file as a snapshot.
   *snapshot_policy = FileSystemFileUtil::kSnapshotFileTemporary;