Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 11358216: Consolidate mass-rename.sh and move_source_file.py (Closed)

Created:
8 years, 1 month ago by Jói
Modified:
8 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Consolidate mass-rename.sh and move_source_file.py BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168926

Patch Set 1 #

Patch Set 2 : Reupload with similarity=30 to see the move diff. #

Total comments: 2

Patch Set 3 : Add support for comments. #

Total comments: 2

Patch Set 4 : Address review comments. #

Total comments: 8

Patch Set 5 : Respond to review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -196 lines) Patch
M tools/git/mass-rename.sh View 2 chunks +2 lines, -31 lines 0 comments Download
A + tools/git/move_source_file.py View 1 2 3 4 2 chunks +115 lines, -44 lines 0 comments Download
D tools/refactor/move_file.py View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jói
Nico, I was thinking about doing this as a follow-up: Adding an import of sort-headers.py ...
8 years, 1 month ago (2012-11-13 16:24:38 UTC) #1
Jói
thakis: friendly ping
8 years, 1 month ago (2012-11-14 16:41:18 UTC) #2
Nico
Do you have numbers of how fast the old version of the sh script was ...
8 years, 1 month ago (2012-11-14 19:03:19 UTC) #3
Jói
> You can do sort_headers = import('sort-headers'), then you don't need to > rename > ...
8 years, 1 month ago (2012-11-14 19:45:19 UTC) #4
Nico
Nice! http://codereview.chromium.org/11358216/diff/1004/tools/git/move_source_file.py File tools/git/move_source_file.py (right): http://codereview.chromium.org/11358216/diff/1004/tools/git/move_source_file.py#newcode31 tools/git/move_source_file.py:31: def MoveFile(from_path, to_path, already_moved): It's a bit confusing ...
8 years, 1 month ago (2012-11-14 19:51:36 UTC) #5
Jói
Added support for updating path references in comments. This made the code a bit messier ...
8 years, 1 month ago (2012-11-15 15:13:10 UTC) #6
Nico
Argh, rietveld somehow ate what I just typed. In short: Is the comment processing really ...
8 years, 1 month ago (2012-11-15 18:19:02 UTC) #7
Nico
(the rest looks good)
8 years, 1 month ago (2012-11-15 18:19:11 UTC) #8
Jói
Removed the comment-finding stuff from this change, as requested. Will move it to the follow-up ...
8 years, 1 month ago (2012-11-20 14:43:12 UTC) #9
Nico
LGTM, some optional comments below. (In particular, no changes required for the first comment) https://codereview.chromium.org/11358216/diff/11002/tools/git/move_source_file.py ...
8 years, 1 month ago (2012-11-20 18:32:39 UTC) #10
Jói
Thanks, responded to the nits, will think about the other for the follow-up change. Committing ...
8 years, 1 month ago (2012-11-20 22:21:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/11358216/14001
8 years, 1 month ago (2012-11-20 22:21:58 UTC) #12
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 00:19:59 UTC) #13
Change committed as 168926

Powered by Google App Engine
This is Rietveld 408576698