Make SignalSenderVerificationTest more robust

dbus/object_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/bus.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 390 matching lines @@
 
 void ObjectProxy::OnConnected(OnConnectedCallback on_connected_callback,
                               const std::string& interface_name,
                               const std::string& signal_name,
                               bool success) {
   bus_->AssertOnOriginThread();
 
   on_connected_callback.Run(interface_name, signal_name, success);
 }
 
+void ObjectProxy::SetNameOwnerChangedCallback(SignalCallback callback) {
+  bus_->AssertOnOriginThread();
+
+  name_owner_changed_callback_ = callback;
+}
+
 DBusHandlerResult ObjectProxy::HandleMessage(
     DBusConnection* connection,
     DBusMessage* raw_message) {
   bus_->AssertOnDBusThread();
 
   if (dbus_message_get_type(raw_message) != DBUS_MESSAGE_TYPE_SIGNAL)
     return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
 
   // raw_message will be unrefed on exit of the function. Increment the
   // reference so we can use it in Signal.
@@ skipping 206 matching lines @@
   if (signal->GetMember() == "NameOwnerChanged" &&
       signal->GetInterface() == "org.freedesktop.DBus" &&
       signal->GetSender() == "org.freedesktop.DBus") {
     MessageReader reader(signal);
     std::string name, old_owner, new_owner;
     if (reader.PopString(&name) &&
         reader.PopString(&old_owner) &&
         reader.PopString(&new_owner) &&
         name == service_name_) {
       service_name_owner_ = new_owner;
+      name_owner_changed_callback_.Run(signal);

[satorux1, 2012/11/12 07:56:43]

This will crash if name_owner_changed_callback_ is null. Can we assume that the
callback is always set? Otherwise, we should check if this is non null.

  

[Haruki Sato, 2012/11/13 06:23:28]

Done. Thanks.

       return DBUS_HANDLER_RESULT_HANDLED;
     }
   }
 
   // Untrusted or uninteresting signal
   return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
 }
 
 }  // namespace dbus