Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 113576: Fix compilation on MinGW (Closed)

Created:
11 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix compilation on MinGW On MinGW _WIN32_WINNT needs to be 0x501 (Windows XP) instead of 0x500 (Windows 2000) for some TCP/IP API's to be present. MinGW uses stdint.h whereas Visual C++ does not. Committed: http://code.google.com/p/v8/source/detail?r=1999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M include/v8.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 7 months ago (2009-05-19 09:26:17 UTC) #1
Lasse Reichstein
11 years, 7 months ago (2009-05-19 09:29:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698