Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: build/mac/tweak_app_infoplist

Issue 113553: Remove two todo's since the pref controls initializing breakpad, and if users... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 2
3 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 set -e 7 set -e
8 8
9 # Pull off the optional args 9 # Pull off the optional args
10 INCLUDE_BREAKPAD=0 10 INCLUDE_BREAKPAD=0
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \ 128 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
129 BreakpadURL "https://clients2.google.com/cr/report" 129 BreakpadURL "https://clients2.google.com/cr/report"
130 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval "3600" 130 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval "3600"
131 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \ 131 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
132 BreakpadProduct "${BUILD_BRANDING}_Mac" 132 BreakpadProduct "${BUILD_BRANDING}_Mac"
133 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \ 133 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
134 BreakpadProductDisplay "${BUILD_BRANDING}" 134 BreakpadProductDisplay "${BUILD_BRANDING}"
135 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \ 135 defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
136 BreakpadVersion -string "${FULL_VERSION}" 136 BreakpadVersion -string "${FULL_VERSION}"
137 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit "YES" 137 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit "YES"
138 # TODO: remove/update this when we have first launch
139 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm "YES" 138 defaults write "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm "YES"
140 else 139 else
141 # Make sure the keys aren't there, || true to avoid errors if they aren't. 140 # Make sure the keys aren't there, || true to avoid errors if they aren't.
142 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadURL || true 141 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadURL || true
143 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval || true 142 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadReportInterval || true
144 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProduct || true 143 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProduct || true
145 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProductDisplay || true 144 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadProductDisplay || true
146 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadVersion || true 145 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadVersion || true
147 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit || true 146 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSendAndExit || true
148 # TODO: remove/update this when we have first launch
149 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm || true 147 defaults delete "${TMP_INFO_PLIST_DEFAULTS}" BreakpadSkipConfirm || true
150 fi 148 fi
151 149
152 # Info.plist will work perfectly well in any plist format, but traditionally 150 # Info.plist will work perfectly well in any plist format, but traditionally
153 # applications use xml1 for this, so convert it back after whatever defaults 151 # applications use xml1 for this, so convert it back after whatever defaults
154 # might have done. 152 # might have done.
155 plutil -convert xml1 "${TMP_INFO_PLIST}" 153 plutil -convert xml1 "${TMP_INFO_PLIST}"
156 cp "${TMP_INFO_PLIST}" "${SRC_APP_PATH}/${INFO_PLIST_PATH}" 154 cp "${TMP_INFO_PLIST}" "${SRC_APP_PATH}/${INFO_PLIST_PATH}"
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698