Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 113549: Hook up stats reporting via default system on OS X. (Closed)

Created:
11 years, 7 months ago by jeremy
Modified:
7 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, pinkerton
Visibility:
Public.

Description

Hook up stats reporting via default system on OS X. Allow enabling/disabling stats via user defaults. Fix breakpad to read from global stats setting. To disable stats, type the following in the terminal: defaults write com.google.Chrome usagestats -bool NO BUG=12046

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -8 lines) Patch
M chrome/app/breakpad_mac.mm View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +4 lines, -1 line 0 comments Download
A chrome/browser/google_update_settings_mac.mm View 1 chunk +87 lines, -0 lines 3 comments Download
A chrome/browser/google_update_settings_mac_unittest.mm View 1 chunk +53 lines, -0 lines 3 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jeremy
11 years, 7 months ago (2009-05-18 21:13:10 UTC) #1
pink (ping after 24hrs)
drive-by review. http://codereview.chromium.org/113549/diff/1/4 File chrome/browser/google_update_settings_mac.mm (right): http://codereview.chromium.org/113549/diff/1/4#newcode31 Line 31: if (val == nil || ![val ...
11 years, 7 months ago (2009-05-18 21:21:09 UTC) #2
John Grabowski
http://codereview.chromium.org/113549/diff/1/4 File chrome/browser/google_update_settings_mac.mm (right): http://codereview.chromium.org/113549/diff/1/4#newcode25 Line 25: // Declared in a public namespace for testing ...
11 years, 7 months ago (2009-05-18 21:49:50 UTC) #3
John Grabowski
11 years, 7 months ago (2009-05-18 21:52:33 UTC) #4
>> Stat not set test (which will be the most common case...)

Doh... is at the top of the file.

LGTM; rest are nits

Powered by Google App Engine
This is Rietveld 408576698