Issue 113546: Force the font size in the omnibox, tabs, find bar, and download shelf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113546: Force the font size in the omnibox, tabs, find bar, and download shelf (Closed)

Created:
11 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, Dean McNamee

Visibility:
Public.

Description

Force the font size in the omnibox, tabs, find bar, and download shelf so we don't get layout overflow issues. Ideally, we would have vector graphics for buttons and stuff so this wouldn't be an issue, but for now, this will have to do. BUG=11128

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/download_item_gtk.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/download_shelf_gtk.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/find_bar_gtk.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/link_button_gtk.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/gtk_util.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

actually, is there some reason not to use pango_font_description_set_size()?

11 years, 7 months ago (2009-05-18 21:06:59 UTC) #3

tony

We want size in pixels rather than points because points depends on the user's DPI. ...

11 years, 7 months ago (2009-05-18 21:09:53 UTC) #4

Evan Stade

11 years, 7 months ago (2009-05-18 21:24:01 UTC) #5

On 2009/05/18 21:09:53, tony wrote:
> We want size in pixels rather than points because points depends on the user's
> DPI.  I think if I use pango_font_descript_set_size, the font size will change
> with DPI changes.

fair enough. I just read up on DPI, which is something I never really
understood, and I think you're right.

Expand Messages | Collapse Messages