Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 113545: Linux: Don't unparent unselected tab contentses.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/tab_contents_container_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_window_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_window_gtk.cc (revision 16301)
+++ chrome/browser/gtk/browser_window_gtk.cc (working copy)
@@ -619,10 +619,9 @@
// We use index here rather than comparing |contents| because by this time
// the model has already removed |contents| from its list, so
// browser_->GetSelectedTabContents() will return NULL or something else.
- if (index == browser_->tabstrip_model()->selected_index()) {
+ if (index == browser_->tabstrip_model()->selected_index())
infobar_container_->ChangeTabContents(NULL);
- contents_container_->SetTabContents(NULL);
- }
+ contents_container_->DetachTabContents(contents);
}
// TODO(estade): this function should probably be unforked from the BrowserView
« no previous file with comments | « no previous file | chrome/browser/gtk/tab_contents_container_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698