Issue 113537: Makes it so tab_strip can compile on linux. Most differences are due...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113537: Makes it so tab_strip can compile on linux. Most differences are due... (Closed)

Created:
11 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes it so tab_strip can compile on linux. Most differences are due to compiler differences between gcc and MSVC. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16319

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -19 lines)			Patch
M	chrome/browser/views/tabs/tab_strip.h	View	5 chunks	+20 lines, -7 lines	1 comment	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	18 chunks	+44 lines, -12 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 7 months ago (2009-05-18 19:25:23 UTC) #2

OK

http://codereview.chromium.org/113537/diff/1/3
File chrome/browser/views/tabs/tab_strip.h (right):

http://codereview.chromium.org/113537/diff/1/3#newcode345
Line 345: #if defined(OS_WIN)
Move the TODO above under this ifdef

Expand Messages | Collapse Messages