Issue 113519: Changed FuncNameInferrer and ScopeInfo to support zone allocation....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113519: Changed FuncNameInferrer and ScopeInfo to support zone allocation.... (Closed)

Created:
11 years, 7 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Kevin Millikin (Google)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed FuncNameInferrer and ScopeInfo to support zone allocation. Yields a 2% speedup when running compiler-benchmark. Committed: http://code.google.com/p/v8/source/detail?r=1985

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -10 lines)			Patch
M	src/codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.h	View	2 chunks	+3 lines, -1 line	1 comment	Download
M	src/factory.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/func-name-inferrer.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/scopeinfo.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-18 09:16:19 UTC) #2

LGTM.

http://codereview.chromium.org/113519/diff/1/5
File src/factory.h (right):

http://codereview.chromium.org/113519/diff/1/5#newcode208
Line 208: Code::Flags flags, Handle<Object> self_reference);
Newline before the Handle<Object>.

Expand Messages | Collapse Messages