Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11348019: Bump English spellcheck dictionary versions and add tests (Closed)

Created:
8 years, 1 month ago by Evan Stade
Modified:
8 years, 1 month ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rpetterson, darin-cc_chromium.org
Visibility:
Public.

Description

Bump English spellcheck dictionary versions and add tests BUG=94708, 98678, 140486, 146093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165562

Patch Set 1 #

Patch Set 2 : anotehr test case #

Patch Set 3 : roll DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/spellcheck_common.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
8 years, 1 month ago (2012-10-30 01:39:53 UTC) #1
Evan Stade
+thestig for owners approval of chrome/common/
8 years, 1 month ago (2012-10-30 17:32:16 UTC) #2
Lei Zhang
lgtm
8 years, 1 month ago (2012-10-30 20:12:44 UTC) #3
Evan Stade
ping groby
8 years, 1 month ago (2012-11-01 00:45:21 UTC) #4
groby-ooo-7-16
8 years, 1 month ago (2012-11-01 21:04:30 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698