Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 113480: Sync git-cl and git-try to the master branch. (Closed)

Created:
11 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Sync git-cl and git-try to the master branch. Remove import readline since it is not used and not available on win32 Fix the tempfile.NamedTemporaryFile() handling on win32. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16220

Patch Set 1 #

Patch Set 2 : Keep import readline but don't fail on ImportError. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M git-cl.py View 1 7 chunks +24 lines, -9 lines 0 comments Download
M git-try.py View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
My first git code review. Fixes git-cl issues on raw win32. Did you really expect ...
11 years, 7 months ago (2009-05-15 20:41:59 UTC) #1
Evan Martin
I don't understand these changes -- aren't they code that already exists in git-cl?
11 years, 7 months ago (2009-05-15 20:45:10 UTC) #2
M-A Ruel
On 2009/05/15 20:45:10, Evan Martin wrote: > I don't understand these changes -- aren't they ...
11 years, 7 months ago (2009-05-15 21:10:00 UTC) #3
Evan Martin
11 years, 7 months ago (2009-05-15 21:14:51 UTC) #4
lgtm rubber stamp

Powered by Google App Engine
This is Rietveld 408576698