Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 113479: Mac: Style the omnibox URL. (Closed)

Created:
11 years, 7 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: Style the omnibox URL. Cribbed this mostly from GTK, including taking their colors pretty directly. The hostname in the URL is a stronger color than the rest of the URL to call it out. The https: scheme is also called out specially. The background color changes when secure. Also cleaned up the selection-setting so that there are distinct code paths for updating the field and setting the selection. Also fixed saving of selection across popup navigation via arrow keys. Also sprinkled some const jimmies while I was in there. http://crbug.com/10939 TEST=Type an URL, does the hostname highlight versus the rest? Do secure URLS look different?

Patch Set 1 #

Patch Set 2 : Fix a couple comments, and saving across popup navigation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -61 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 13 chunks +129 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
Tossing this at you because you complained about focus-stealing. If this helps, it wasn't the ...
11 years, 7 months ago (2009-05-15 21:20:44 UTC) #1
Avi (use Gerrit)
The code LG. This doesn't fix the focus stealing, though.
11 years, 7 months ago (2009-05-15 21:45:53 UTC) #2
Scott Hess - ex-Googler
11 years, 7 months ago (2009-05-15 22:29:47 UTC) #3
On 2009/05/15 21:45:53, Avi wrote:
> The code LG. This doesn't fix the focus stealing, though.

Darn.  Now I have no reason to not buckle down and poke at that bug.

Powered by Google App Engine
This is Rietveld 408576698