Issue 113469: Enable SVG fonts regardless of whether remoteFontEnabled is on or not. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113469: Enable SVG fonts regardless of whether remoteFontEnabled is on or not. ... (Closed)

Created:
11 years, 7 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Mark Larson, dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/

Visibility:
Public.

Description

Enable SVG fonts regardless of whether remoteFontEnabled is on or not. BUG=9633 TEST= http://acid3.acidtests.org/ should get 100/100, with no boxes in the upper right corner (still has the Linktest Failed error). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16169

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/WebCore/css/CSSFontSelector.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

Dimitri, do I have to worry about cases where SVG_FONTS is not defined? (foundSVGFont is ...

11 years, 7 months ago (2009-05-15 18:37:49 UTC) #1

jungshik at Google

On 2009/05/15 18:37:49, Jungshik Shin wrote: > Dimitri, do I have to worry about cases ...

11 years, 7 months ago (2009-05-15 18:41:40 UTC) #2

Mark Larson

LGTM I updated the TEST line in the description. Not sure if gcl picks that ...

11 years, 7 months ago (2009-05-15 18:51:32 UTC) #3

jungshik at Google

11 years, 7 months ago (2009-05-15 19:18:34 UTC) #4

On 2009/05/15 18:51:32, Mark Larson wrote:
> LGTM 
> 
> I updated the TEST line in the description. Not sure if gcl picks that up on
> commit or just uses the local copy.

Thanks for updating the TEST line. To get that in, I'll update my local copy
before landing.

Expand Messages | Collapse Messages