Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 113458: First round of size reduction for JumpTargets. Reduce their size by... (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

First round of size reduction for JumpTargets. Reduce their size by two words: there is no reason to keep a pointer to the current code generator and macro assembler in the JumpTarget. Committed: http://code.google.com/p/v8/source/detail?r=1987

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -430 lines) Patch
M src/arm/codegen-arm.cc View 38 chunks +69 lines, -69 lines 0 comments Download
M src/arm/jump-target-arm.cc View 15 chunks +45 lines, -48 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 43 chunks +77 lines, -82 lines 0 comments Download
M src/ia32/jump-target-ia32.cc View 15 chunks +58 lines, -58 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/jump-target.h View 1 3 chunks +19 lines, -23 lines 2 comments Download
M src/jump-target.cc View 1 20 chunks +85 lines, -147 lines 0 comments Download
M src/jump-target-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
11 years, 7 months ago (2009-05-15 12:50:21 UTC) #1
Kevin Millikin (Chromium)
LGTM. Now that the BreakTarget subclass doesn't need to have a code generator or macro ...
11 years, 7 months ago (2009-05-18 07:58:27 UTC) #2
Mads Ager (chromium)
On 2009/05/18 07:58:27, Kevin Millikin wrote: > LGTM. > > Now that the BreakTarget subclass ...
11 years, 7 months ago (2009-05-18 11:24:01 UTC) #3
William Hesse
LGTM. http://codereview.chromium.org/113458/diff/1014/24 File src/jump-target.h (right): http://codereview.chromium.org/113458/diff/1014/24#newcode59 Line 59: // Construct a jump target with a ...
11 years, 7 months ago (2009-05-18 12:18:24 UTC) #4
Mads Ager (chromium)
11 years, 7 months ago (2009-05-18 12:21:37 UTC) #5
On 2009/05/18 12:18:24, William Hesse wrote:
> LGTM.
> 
> http://codereview.chromium.org/113458/diff/1014/24
> File src/jump-target.h (right):
> 
> http://codereview.chromium.org/113458/diff/1014/24#newcode59
> Line 59: // Construct a jump target with a given code generator used to
generate
> This comment should be changed.

Done.

> http://codereview.chromium.org/113458/diff/1014/24#newcode68
> Line 68: // Construct a jump target without a code generator.  A code
> This comment should be changed.

Done.

Powered by Google App Engine
This is Rietveld 408576698