Issue 113457: Try to preallocate the scratch registers used for inlined keyed loads...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113457: Try to preallocate the scratch registers used for inlined keyed loads... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Try to preallocate the scratch registers used for inlined keyed loads to allow fast entry to the deferred code if possible. Committed: http://code.google.com/p/v8/source/detail?r=1968

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -13 lines)			Patch
M	src/codegen.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/codegen-inl.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	4 chunks	+30 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Chromium)

Doesn't make much performance difference on the compiler benchmark.

11 years, 7 months ago (2009-05-15 11:42:10 UTC) #1

Kasper Lund

11 years, 7 months ago (2009-05-15 11:46:47 UTC) #3

LGTM, but I'm a bit concerned that we're adding a lot of logic if it doesn't
really pay off.