Clean up the Result class. Reduce the size of Result from four words...

src/codegen.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 68 matching lines @@
 
 
 #if V8_TARGET_ARCH_IA32
 #include "ia32/codegen-ia32.h"
 #elif V8_TARGET_ARCH_X64
 #include "x64/codegen-x64.h"
 #elif V8_TARGET_ARCH_ARM
 #include "arm/codegen-arm.h"
 #endif
 
+#include "register-allocator.h"
+
 namespace v8 { namespace internal {
 
 
+// Code generation can be nested.  Code generation scopes form a stack
+// of active code generators.
+class CodeGeneratorScope BASE_EMBEDDED {
+ public:
+  explicit CodeGeneratorScope(CodeGenerator* cgen) {
+    previous = Result::cgen_;

[Kevin Millikin (Chromium), 2009/05/15 10:50:49]

Does the static top code generator belong to the Result?  I can see it being
used elsewhere (JumpTarget).  Maybe it fits better in CodeGeneratorScope or
CodeGenerator.

[Mads Ager (chromium), 2009/05/15 11:05:25]

Good point.  I moved it to the CodeGeneratorScope.  Whenever you need the
current CodeGenerator you can get it as CodeGeneratorScope::Current().

+    Result::cgen_ = cgen;
+  }
+  ~CodeGeneratorScope() {
+    Result::cgen_ = previous;
+  }
+ private:
+  CodeGenerator* previous;
+};
+
+
 // Use lazy compilation; defaults to true.
 // NOTE: Do not remove non-lazy compilation until we can properly
 //       install extensions with lazy compilation enabled. At the
 //       moment, this doesn't work for the extensions in Google3,
 //       and we can only run the tests with --nolazy.
 
 
 // Deferred code objects are small pieces of code that are compiled
 // out of line. They are used to defer the compilation of uncommon
 // paths thereby avoiding expensive jumps around uncommon code parts.
@@ skipping 219 matching lines @@
     PrintF("ArgumentsAccessStub (type %d)\n", type_);
   }
 #endif
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODEGEN_H_