Issue 113452: Move/Copy paths used by app to app_paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113452: Move/Copy paths used by app to app_paths. (Closed)

Created:
11 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move/Copy paths used by app to app_paths. http://crbug.com/11387 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16173

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -335 lines)			Patch
M	app/DEPS	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	app/app.vcproj	View	1 2	1 chunk	+303 lines, -295 lines	0 comments	Download
M	app/gfx/icon_util_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	app/l10n_util.cc	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
M	app/l10n_util_unittest.cc	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	app/resource_bundle_linux.cc	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	app/resource_bundle_win.cc	View	1 2	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_paths.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_paths.cc	View	1 2	1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/test/data/icon_util/128_X_128_icon.ico	View		Binary file		0 comments	Download
D	chrome/test/data/icon_util/16_X_16_icon.ico	View		Binary file		0 comments	Download
M	views/DEPS	View	2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 7 months ago (2009-05-15 16:32:06 UTC) #2

LGTM

http://codereview.chromium.org/113452/diff/22/1024
File app/app_paths.h (right):

http://codereview.chromium.org/113452/diff/22/1024#newcode16
Line 16: DIR_THEMES,            // directory where theme dll files are stored
Can you make these comments begin with a capital and end with a period?

Expand Messages | Collapse Messages