Issue 113451: Polish code of VirtualFrame::MoveMemoryToRegister

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113451: Polish code of VirtualFrame::MoveMemoryToRegister (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Polish code of VirtualFrame::MoveMemoryToRegister Committed: http://code.google.com/p/v8/source/detail?r=1963

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	src/ia32/virtual-frame-ia32.cc	View	1	2 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 7 months ago (2009-05-15 09:20:32 UTC) #2

http://codereview.chromium.org/113451/diff/1/2
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/113451/diff/1/2#newcode426
Line 426: Register target_reg = { i };
This strikes me as weird. It seems like there are two  uses of
expected->elements_[index] left (three if you count the assert). Why not keep
target as it is and introduce target_reg in addition to that?

Expand Messages | Collapse Messages