Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6302)

Unified Diff: chrome/browser/signin/signin_manager.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_manager.cc
diff --git a/chrome/browser/signin/signin_manager.cc b/chrome/browser/signin/signin_manager.cc
index b6ac90f6eb0922c25601cc760a94fd0fcd6671c0..2f8c6fe50b1cd961bdc566beef556f1a8fa94848 100644
--- a/chrome/browser/signin/signin_manager.cc
+++ b/chrome/browser/signin/signin_manager.cc
@@ -497,17 +497,6 @@ void SigninManager::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case chrome::NOTIFICATION_PREF_CHANGED:
- DCHECK(*content::Details<std::string>(details).ptr() ==
- prefs::kGoogleServicesUsernamePattern);
- if (!authenticated_username_.empty() &&
- !IsAllowedUsername(authenticated_username_)) {
- // Signed in user is invalid according to the current policy so sign
- // the user out.
- SignOut();
- }
- break;
-
#if !defined(OS_CHROMEOS)
case chrome::NOTIFICATION_TOKEN_AVAILABLE: {
TokenService::TokenAvailableDetails* tok_details =
@@ -537,3 +526,13 @@ void SigninManager::Observe(int type,
}
}
+void SigninManager::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK_EQ(prefs::kGoogleServicesUsernamePattern, pref_name);
+ if (!authenticated_username_.empty() &&
+ !IsAllowedUsername(authenticated_username_)) {
+ // Signed in user is invalid according to the current policy so sign
+ // the user out.
+ SignOut();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698