Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/net/net_pref_observer.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/prefs/public/pref_observer.h ('K') | « chrome/browser/net/net_pref_observer.h ('k') | chrome/browser/net/pref_proxy_config_tracker_impl.h » ('j') | chrome/browser/prefs/pref_notifier_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/net_pref_observer.cc
diff --git a/chrome/browser/net/net_pref_observer.cc b/chrome/browser/net/net_pref_observer.cc
index 4ccf1945286d7a22276a0506407c21acb7e0d167..e985609039ee1781b4dc55a821d4e5e3967c0a3c 100644
--- a/chrome/browser/net/net_pref_observer.cc
+++ b/chrome/browser/net/net_pref_observer.cc
@@ -34,10 +34,8 @@ NetPrefObserver::~NetPrefObserver() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
}
-void NetPrefObserver::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- DCHECK_EQ(type, chrome::NOTIFICATION_PREF_CHANGED);
+void NetPrefObserver::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
ApplySettings();
}
« base/prefs/public/pref_observer.h ('K') | « chrome/browser/net/net_pref_observer.h ('k') | chrome/browser/net/pref_proxy_config_tracker_impl.h » ('j') | chrome/browser/prefs/pref_notifier_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698