Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index d28013b1c626567038c5ea4a5518323fa06d7e81..b143b8c0eb81f2d4de0fbe047b96ea4216f474a4 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -604,20 +604,14 @@ bool BrowserProcessImpl::plugin_finder_disabled() const {
return false;
}
-void BrowserProcessImpl::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- if (type == chrome::NOTIFICATION_PREF_CHANGED) {
- std::string* pref = content::Details<std::string>(details).ptr();
- if (*pref == prefs::kDefaultBrowserSettingEnabled) {
- ApplyDefaultBrowserPolicy();
- } else if (*pref == prefs::kDisabledSchemes) {
- ApplyDisabledSchemesPolicy();
- } else if (*pref == prefs::kAllowCrossOriginAuthPrompt) {
- ApplyAllowCrossOriginAuthPromptPolicy();
- }
- } else {
- NOTREACHED();
+void BrowserProcessImpl::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref) {
+ if (pref == prefs::kDefaultBrowserSettingEnabled) {
+ ApplyDefaultBrowserPolicy();
+ } else if (pref == prefs::kDisabledSchemes) {
+ ApplyDisabledSchemesPolicy();
+ } else if (pref == prefs::kAllowCrossOriginAuthPrompt) {
+ ApplyAllowCrossOriginAuthPromptPolicy();
}
}

Powered by Google App Engine
This is Rietveld 408576698