Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: base/prefs/public/pref_service_base.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/prefs/public/pref_service_base.h
diff --git a/base/prefs/public/pref_service_base.h b/base/prefs/public/pref_service_base.h
index aa5b3fd823da28b7fae8a28f047ac319c422bd28..131d221776b7e4345f0cc8aecf65b63bf48f945f 100644
--- a/base/prefs/public/pref_service_base.h
+++ b/base/prefs/public/pref_service_base.h
@@ -20,7 +20,6 @@
namespace content {
class BrowserContext;
-class NotificationObserver;
}
namespace subtle {
@@ -28,6 +27,7 @@ class PrefMemberBase;
}
class FilePath;
+class PrefObserver;
class Profile;
class TabContents;
@@ -259,14 +259,12 @@ class PrefServiceBase {
// These are protected so they can only be accessed by the friend
// classes listed above.
//
- // If the pref at the given path changes, we call the observer's Observe
- // method with PREF_CHANGED. Note that observers should not call these methods
- // directly but rather use a PrefChangeRegistrar to make sure the observer
- // gets cleaned up properly.
- virtual void AddPrefObserver(const char* path,
- content::NotificationObserver* obs) = 0;
- virtual void RemovePrefObserver(const char* path,
- content::NotificationObserver* obs) = 0;
+ // If the pref at the given path changes, we call the observer's
+ // OnPreferenceChanged method. Note that observers should not call
+ // these methods directly but rather use a PrefChangeRegistrar to
+ // make sure the observer gets cleaned up properly.
+ virtual void AddPrefObserver(const char* path, PrefObserver* obs) = 0;
+ virtual void RemovePrefObserver(const char* path, PrefObserver* obs) = 0;
};
#endif // BASE_PREFS_PUBLIC_PREF_SERVICE_BASE_H_

Powered by Google App Engine
This is Rietveld 408576698