Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix PrefNotifierImpl Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 99778a1d5963f6ac8d85f628e4b30b56c1ac422e..28975cf4cf9281ee395c6c9dbc7feaeff7d682a1 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2590,17 +2590,6 @@ void ExtensionService::Observe(int type,
process->GetID()));
break;
}
- case chrome::NOTIFICATION_PREF_CHANGED: {
- std::string* pref_name = content::Details<std::string>(details).ptr();
- if (*pref_name == prefs::kExtensionInstallAllowList ||
- *pref_name == prefs::kExtensionInstallDenyList) {
- IdentifyAlertableExtensions();
- CheckManagementPolicy();
- } else {
- NOTREACHED() << "Unexpected preference name.";
- }
- break;
- }
case chrome::NOTIFICATION_IMPORT_FINISHED: {
InitAfterImport();
break;
@@ -2611,6 +2600,17 @@ void ExtensionService::Observe(int type,
}
}
+void ExtensionService::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ if (pref_name == prefs::kExtensionInstallAllowList ||
+ pref_name == prefs::kExtensionInstallDenyList) {
+ IdentifyAlertableExtensions();
+ CheckManagementPolicy();
+ } else {
+ NOTREACHED() << "Unexpected preference name.";
+ }
+}
+
bool ExtensionService::HasApps() const {
return !GetAppIds().empty();
}

Powered by Google App Engine
This is Rietveld 408576698