Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3150)

Unified Diff: chrome/browser/ui/webui/options/preferences_browsertest.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/preferences_browsertest.cc
diff --git a/chrome/browser/ui/webui/options/preferences_browsertest.cc b/chrome/browser/ui/webui/options/preferences_browsertest.cc
index 676227df678c3ad8e08cabde5f1b5ac29e79ab61..5f313476260adef5b8b887de561678a58c7eeb5e 100644
--- a/chrome/browser/ui/webui/options/preferences_browsertest.cc
+++ b/chrome/browser/ui/webui/options/preferences_browsertest.cc
@@ -162,14 +162,10 @@ void PreferencesBrowserTest::SetUpOnMainThread() {
}
// Forwards notifications received when pref values change in the backend.
-void PreferencesBrowserTest::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- ASSERT_EQ(chrome::NOTIFICATION_PREF_CHANGED, type);
- ASSERT_EQ(pref_service_, content::Source<PrefService>(source).ptr());
- const std::string& name = *content::Details<std::string>(details).ptr();
- OnCommit(pref_service_->FindPreference(name.c_str()));
+void PreferencesBrowserTest::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ ASSERT_EQ(pref_service_, service);
+ OnCommit(pref_service_->FindPreference(pref_name.c_str()));
}
// Sets up a mock user policy provider.
« no previous file with comments | « chrome/browser/ui/webui/options/preferences_browsertest.h ('k') | chrome/browser/ui/webui/options/startup_pages_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698