chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h - Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head for commit Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

index 82b9298f07f4b2cc4aec1d3abe4e51e48a7342dc..e14625acc699e11227f36892f9f9eea9e8048c3f 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h

@@ -8,6 +8,7 @@

#include "base/compiler_specific.h"

#include "base/memory/weak_ptr.h"

#include "base/prefs/public/pref_change_registrar.h"

+#include "base/prefs/public/pref_observer.h"

#include "chrome/browser/ui/webui/options/core_options_handler.h"

namespace chromeos {

@@ -37,6 +38,10 @@ class CoreChromeOSOptionsHandler : public ::options::CoreOptionsHandler {

const content::NotificationSource& source,

const content::NotificationDetails& details) OVERRIDE;

+ // PrefObserver implementation.

+ virtual void OnPreferenceChanged(PrefServiceBase* service,

+ const std::string& pref_name) OVERRIDE;

private:

// Notifies registered JS callbacks on ChromeOS setting change.

void NotifySettingsChanged(const std::string* setting_name);