Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/translate/translate_manager.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_prefs.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager.h
diff --git a/chrome/browser/translate/translate_manager.h b/chrome/browser/translate/translate_manager.h
index 93eca3a9c3a159878205d70415857cb7e6cb2d2d..a94a7be9b16d3148ab5483bc2bf77a623b9556a7 100644
--- a/chrome/browser/translate/translate_manager.h
+++ b/chrome/browser/translate/translate_manager.h
@@ -15,6 +15,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/prefs/public/pref_change_registrar.h"
+#include "base/prefs/public/pref_observer.h"
#include "base/time.h"
#include "chrome/common/translate_errors.h"
#include "content/public/browser/notification_observer.h"
@@ -25,6 +26,7 @@ template <typename T> struct DefaultSingletonTraits;
class GURL;
struct PageTranslatedDetails;
class PrefService;
+class PrefServiceBase;
class TranslateInfoBarDelegate;
namespace content {
@@ -41,6 +43,7 @@ class URLFetcher;
// It is a singleton.
class TranslateManager : public content::NotificationObserver,
+ public PrefObserver,
public net::URLFetcherDelegate {
public:
// Returns the singleton instance.
@@ -82,6 +85,10 @@ class TranslateManager : public content::NotificationObserver,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // PrefObserver implementation:
+ virtual void OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) OVERRIDE;
+
// net::URLFetcherDelegate implementation:
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
@@ -167,7 +174,7 @@ class TranslateManager : public content::NotificationObserver,
// Initializes the |accept_languages_| language table based on the associated
// preference in |prefs|.
- void InitAcceptLanguages(PrefService* prefs);
+ void InitAcceptLanguages(PrefServiceBase* prefs);
// Fetches the JS translate script (the script that is injected in the page
// to translate it).
@@ -199,7 +206,7 @@ class TranslateManager : public content::NotificationObserver,
// A map that associates a profile with its parsed "accept languages".
typedef std::set<std::string> LanguageSet;
- typedef std::map<PrefService*, LanguageSet> PrefServiceLanguagesMap;
+ typedef std::map<PrefServiceBase*, LanguageSet> PrefServiceLanguagesMap;
PrefServiceLanguagesMap accept_languages_;
base::WeakPtrFactory<TranslateManager> weak_method_factory_;
« no previous file with comments | « chrome/browser/sync/sync_prefs.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698