Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.h
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.h b/chrome/browser/ui/webui/options/content_settings_handler.h
index 63a83aead2d6c0c5a8f8bec7e7bdc66b9dd1839e..eb4d6acab73bd36f8510f222e7f80fb654a9b876 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.h
+++ b/chrome/browser/ui/webui/options/content_settings_handler.h
@@ -10,6 +10,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/prefs/public/pref_change_registrar.h"
+#include "base/prefs/public/pref_observer.h"
#include "chrome/browser/pepper_flash_settings_manager.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
#include "chrome/common/content_settings.h"
@@ -22,8 +23,10 @@ class ProtocolHandlerRegistry;
namespace options {
-class ContentSettingsHandler : public OptionsPageUIHandler,
- public PepperFlashSettingsManager::Client {
Mattias Nissler (ping if slow) 2012/10/31 13:29:36 Any reasons to reformat this? I think this is lega
Jói 2012/10/31 14:56:26 I don't have to reformat it (or the others where i
+class ContentSettingsHandler
+ : public OptionsPageUIHandler,
+ public PepperFlashSettingsManager::Client,
+ public PrefObserver {
public:
ContentSettingsHandler();
virtual ~ContentSettingsHandler();
@@ -40,6 +43,10 @@ class ContentSettingsHandler : public OptionsPageUIHandler,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // PrefObserver implementation.
+ virtual void OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) OVERRIDE;
+
// PepperFlashSettingsManager::Client implementation.
virtual void OnGetPermissionSettingsCompleted(
uint32 request_id,

Powered by Google App Engine
This is Rietveld 408576698