Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6782)

Unified Diff: chrome/browser/ui/prefs/prefs_tab_helper.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/prefs/prefs_tab_helper.h
diff --git a/chrome/browser/ui/prefs/prefs_tab_helper.h b/chrome/browser/ui/prefs/prefs_tab_helper.h
index c55746ae058189b382dc650345c24c0759456963..bbd1402ca35a9c31847b29138a590b916ccf0a66 100644
--- a/chrome/browser/ui/prefs/prefs_tab_helper.h
+++ b/chrome/browser/ui/prefs/prefs_tab_helper.h
@@ -7,6 +7,7 @@
#include "base/compiler_specific.h"
#include "base/prefs/public/pref_change_registrar.h"
+#include "base/prefs/public/pref_observer.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -21,6 +22,7 @@ class WebContents;
// Per-tab class to handle user preferences.
class PrefsTabHelper : public content::NotificationObserver,
+ public PrefObserver,
public content::WebContentsUserData<PrefsTabHelper> {
public:
virtual ~PrefsTabHelper();
@@ -41,6 +43,10 @@ class PrefsTabHelper : public content::NotificationObserver,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // PrefObserver overrides:
+ virtual void OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) OVERRIDE;
+
// Update the WebContents's RendererPreferences.
void UpdateRendererPreferences();

Powered by Google App Engine
This is Rietveld 408576698