Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5730)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index b3bdca7e9620690d691bf921cea4113b622e4c92..f166bac6a07d9171dc3a9a6459999e295cd096d0 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -409,18 +409,17 @@ void TranslateManager::Observe(int type,
delete pref_change_registrar;
break;
}
- case chrome::NOTIFICATION_PREF_CHANGED: {
- DCHECK(*content::Details<std::string>(details).ptr() ==
- prefs::kAcceptLanguages);
- PrefService* prefs = content::Source<PrefService>(source).ptr();
- InitAcceptLanguages(prefs);
- break;
- }
default:
NOTREACHED();
}
}
+void TranslateManager::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK_EQ(std::string(prefs::kAcceptLanguages), pref_name);
+ InitAcceptLanguages(static_cast<PrefService*>(service));
Mattias Nissler (ping if slow) 2012/10/31 13:29:36 Can we do without the cast?
Jói 2012/10/31 14:56:26 Done.
+}
+
void TranslateManager::OnURLFetchComplete(const net::URLFetcher* source) {
if (translate_script_request_pending_.get() != source &&
language_list_request_pending_.get() != source) {

Powered by Google App Engine
This is Rietveld 408576698