Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3931)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index a5d8829d6b27c798253ed06702267a49b5654a90..1a2a616cba428b8129db5f5a5bdbd967bed968ac 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -1366,18 +1366,18 @@ void SafeBrowsingService::Observe(int type,
RemovePrefService(profile->GetPrefs());
break;
}
- case chrome::NOTIFICATION_PREF_CHANGED: {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- std::string* pref = content::Details<std::string>(details).ptr();
- DCHECK(*pref == prefs::kSafeBrowsingEnabled);
- RefreshState();
- break;
- }
default:
NOTREACHED();
}
}
+void SafeBrowsingService::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK(pref_name == prefs::kSafeBrowsingEnabled);
+ RefreshState();
+}
+
bool SafeBrowsingService::IsWhitelisted(const UnsafeResource& resource) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// Check if the user has already ignored our warning for this render_view

Powered by Google App Engine
This is Rietveld 408576698