Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge LKGR. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index cc1ea1bcc7d25aa9a5de71c4b973dc303f7b153a..5e347bee7cb58caf5f8a83640de3997ff4ca9d31 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2581,16 +2581,6 @@ void ExtensionService::Observe(int type,
process->GetID()));
break;
}
- case chrome::NOTIFICATION_PREF_CHANGED: {
- const std::string& pref_name =
- *content::Details<std::string>(details).ptr();
- DCHECK(pref_name == prefs::kExtensionInstallAllowList ||
- pref_name == prefs::kExtensionInstallDenyList)
- << "Unexpected preference name " << pref_name;
- IdentifyAlertableExtensions();
- CheckManagementPolicy();
- break;
- }
case chrome::NOTIFICATION_IMPORT_FINISHED: {
InitAfterImport();
break;
@@ -2601,6 +2591,15 @@ void ExtensionService::Observe(int type,
}
}
+void ExtensionService::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK(pref_name == prefs::kExtensionInstallAllowList ||
+ pref_name == prefs::kExtensionInstallDenyList)
+ << "Unexpected preference name " << pref_name;
+ IdentifyAlertableExtensions();
+ CheckManagementPolicy();
+}
+
bool ExtensionService::HasApps() const {
return !GetAppIds().empty();
}

Powered by Google App Engine
This is Rietveld 408576698