Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: chrome/browser/api/prefs/pref_member.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/api/prefs/pref_member.cc
diff --git a/chrome/browser/api/prefs/pref_member.cc b/chrome/browser/api/prefs/pref_member.cc
index 46f2aa60cd4229c4d0fdb0ce5a082668230d5126..e81b13a61081620b7495dbb94ac4f697fe0d344d 100644
--- a/chrome/browser/api/prefs/pref_member.cc
+++ b/chrome/browser/api/prefs/pref_member.cc
@@ -8,7 +8,6 @@
#include "base/location.h"
#include "base/prefs/public/pref_service_base.h"
#include "base/value_conversions.h"
-#include "chrome/common/chrome_notification_types.h"
using base::MessageLoopProxy;
@@ -26,7 +25,7 @@ PrefMemberBase::~PrefMemberBase() {
void PrefMemberBase::Init(const char* pref_name,
PrefServiceBase* prefs,
- content::NotificationObserver* observer) {
+ PrefObserver* observer) {
DCHECK(pref_name);
DCHECK(prefs);
DCHECK(pref_name_.empty()); // Check that Init is only called once.
@@ -57,14 +56,12 @@ void PrefMemberBase::MoveToThread(
internal()->MoveToThread(message_loop);
}
-void PrefMemberBase::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
+void PrefMemberBase::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
VerifyValuePrefName();
- DCHECK(chrome::NOTIFICATION_PREF_CHANGED == type);
UpdateValueFromPref();
if (!setting_value_ && observer_)
- observer_->Observe(type, source, details);
+ observer_->OnPreferenceChanged(service, pref_name);
}
void PrefMemberBase::UpdateValueFromPref() const {

Powered by Google App Engine
This is Rietveld 408576698